feat: expose Everyone group through UI #9117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ad3520 to
2c7b98d
Compare
|
PR title should be about exposing everyone group through the UI right? |
Emyrk
requested changes
Aug 16, 2023
ammario
requested changes
Aug 17, 2023
| func ReadModifyUpdate(db Store, f func(tx Store) error, | ||
| ) error { | ||
| var err error | ||
| for retries := 0; retries < maxRetries; retries++ { |
There was a problem hiding this comment.
Curious about the decision to not use retry logic and spin. Is there a thundering herd risk?
There was a problem hiding this comment.
Inspired by this function, I added Jitter to our retry package: https://pkg.go.dev/github.com/coder/retry#Retrier.
There was a problem hiding this comment.
Honestly I just copied this from v1. In the interest of getting this PR merged I'd like to leave it as-is.
ammario
approved these changes
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend Behavior Changes:
nameanddisplayinGroup Settingspage when group isEveryone.Grouppage when group isEveryone.Grouppage when group isEveryone.Backend Behavior Changes;
Everyonegroup.GET /groupsendpoint now returns theEveryonegroup.name,display_namein backend forEveryone. Allows updatingquota_allowanceandavatar_url(why not)fixes #6518