Skip to content

feat(site): display build logs history in the build log page #9150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 17, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Close #7409

Demo:

Screen.Recording.2023-08-16.at.15.05.07.mov

@BrunoQuaresma BrunoQuaresma self-assigned this Aug 17, 2023
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

A few things I noticed clicking around:

  1. I kind of miss a "back to workspace" button, I know the workspace name is clickable, but it feels a bit hidden away / not natural flow
  2. The Builds list could also show #1, #2, etc.
  3. When opening the builds page, the Builds list quickly flashes the loading indicator, don't we already have the builds since they're listed in the workspace page? Could we re-use that for a smoother experience?

@BrunoQuaresma
Copy link
Collaborator Author

@mafredri very valid points!

  1. This is a good one, I will see how I can solve this a next time. This is a problem that is related not only to this page but the full-page header layout.
  2. That is true, I just don't see how to add it without making it too heavy visually but I will think of something.
  3. Even the loading indicator being a skeleton (an element placeholder) you found it strange? Right now, we are not keeping the previous data because we don't have a single way to fetch server data, I hope to fix that this year but it would happen in a page refresh for example.

@mafredri
Copy link
Member

  1. Even the loading indicator being a skeleton (an element placeholder) you found it strange? Right now, we are not keeping the previous data because we don't have a single way to fetch server data, I hope to fix that this year but it would happen in a page refresh for example.

Yeah, it felt a bit weird since it resulted in some flashing (as in, it appeared and disappeared quite quickly). I think in a full page reload it's fine, both because of expectations and it will likely not flash as much since loading might take longer (multiple requests).

@BrunoQuaresma BrunoQuaresma merged commit 9caa4cf into main Aug 17, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/improve-build-logs-page branch August 17, 2023 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show historical startup logs in build logs page
3 participants