-
Notifications
You must be signed in to change notification settings - Fork 887
feat(site): display build logs history in the build log page #9150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change!
A few things I noticed clicking around:
- I kind of miss a "back to workspace" button, I know the workspace name is clickable, but it feels a bit hidden away / not natural flow
- The
Builds
list could also show#1
,#2
, etc. - When opening the builds page, the
Builds
list quickly flashes the loading indicator, don't we already have the builds since they're listed in the workspace page? Could we re-use that for a smoother experience?
@mafredri very valid points!
|
Yeah, it felt a bit weird since it resulted in some flashing (as in, it appeared and disappeared quite quickly). I think in a full page reload it's fine, both because of expectations and it will likely not flash as much since loading might take longer (multiple requests). |
Close #7409
Demo:
Screen.Recording.2023-08-16.at.15.05.07.mov