Skip to content

feat: Add update profile endpoint #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 12, 2022
Merged

feat: Add update profile endpoint #916

merged 16 commits into from
Apr 12, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Apr 7, 2022 •
edited
Loading

Related to #975

@BrunoQuaresma BrunoQuaresma requested review from Emyrk and kylecarbs April 7, 2022 20:04
BrunoQuaresma
BrunoQuaresma commented Apr 7, 2022
View reviewed changes
@coder coder deleted a comment from codecov bot Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022 •
edited
Loading

Codecov Report

Merging #916 (4531e0d) into main (313b51d) will increase coverage by 0.03%.
The diff coverage is 80.21%.

@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
+ Coverage   65.85%   65.88%   +0.03%     
==========================================
  Files         218      216       -2     
  Lines       13849    13919      +70     
  Branches      103      103              
==========================================
+ Hits         9120     9171      +51     
- Misses       3803     3813      +10     
- Partials      926      935       +9
Flag Coverage Δ
unittest-go-macos-latest ?
unittest-go-postgres- 65.62% <80.21%> (-0.09%) ⬇️
unittest-go-ubuntu-latest 55.43% <57.14%> (+0.19%) ⬆️
unittest-go-windows-2022 52.30% <57.14%> (+0.08%) ⬆️
unittest-js 59.09% <ø> (ø)
Impacted Files Coverage Δ
codersdk/users.go 65.86% <72.72%> (+0.48%) ⬆️
coderd/users.go 58.58% <74.13%> (+1.18%) ⬆️
coderd/coderd.go 96.89% <100.00%> (+0.01%) ⬆️
coderd/database/queries.sql.go 84.00% <100.00%> (+0.24%) ⬆️
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
codersdk/provisionerdaemons.go 58.46% <0.00%> (-6.16%) ⬇️
coderd/workspaceresources.go 56.09% <0.00%> (-4.88%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
provisionerd/provisionerd.go 78.56% <0.00%> (-1.18%) ⬇️
coderd/provisionerdaemons.go 61.55% <0.00%> (-0.51%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313b51d...4531e0d. Read the comment docs.

@BrunoQuaresma
Copy link
Collaborator Author

I ran make fmt but the style job stills failing 🤔

f0ssel
f0ssel reviewed Apr 7, 2022
View reviewed changes
kylecarbs
kylecarbs requested changes Apr 7, 2022
View reviewed changes
Emyrk
Emyrk reviewed Apr 8, 2022
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 comment on the name field. We should use the existing name field if the new name field is "" or nil

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 8, 2022
@BrunoQuaresma BrunoQuaresma requested a review from Emyrk April 8, 2022 18:46
kylecarbs
kylecarbs requested changes Apr 10, 2022
View reviewed changes
@BrunoQuaresma BrunoQuaresma changed the title feat: Add PATCH /users/{user} endpoint feat: Add profile endpoint Apr 12, 2022
@BrunoQuaresma BrunoQuaresma changed the title feat: Add profile endpoint feat: Add update profile endpoint Apr 12, 2022
@BrunoQuaresma BrunoQuaresma requested a review from kylecarbs April 12, 2022 13:16
kylecarbs
kylecarbs reviewed Apr 12, 2022
View reviewed changes
@BrunoQuaresma BrunoQuaresma requested a review from kylecarbs April 12, 2022 13:39
kylecarbs
kylecarbs approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) April 12, 2022 13:52
@BrunoQuaresma BrunoQuaresma merged commit 63d1465 into main Apr 12, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/users-crud branch April 12, 2022 14:05
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@f0ssel f0ssel Awaiting requested review from f0ssel

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
5 participants
@BrunoQuaresma @Emyrk @kylecarbs @f0ssel @misskniss