Skip to content

feat(site): improve template publishing flow #9346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 28, 2023
Merged

feat(site): improve template publishing flow #9346

merged 6 commits into from
Aug 28, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 25, 2023 •
edited
Loading

Fixes #9243

Screenshot 2023-08-25 at 3 02 09 PM

Flagship feature of this PR is the new success banner that appears after publishing a new version. It includes a button to allow quickly creating a new workspace using the template. 🥳

It also has...

  • a couple minor tweaks to some state management to clean up some recently introduced bugs
  • a change to make published versions "active" by default
  • a little bit of general cleanup.

Follow up issues/TODO

  • The "Create a new workspace" button just directs you towards the normal new workspace page, and is not actually tied to the version you just published. We need to do some further work to allow creating a workspace from any version of a template, and tie this button to the just-published version in the future.

@aslilac aslilac requested review from BrunoQuaresma and bpmct August 25, 2023 21:05
@aslilac aslilac changed the title feat(site): Improved template publishing flow feat(site): improve template publishing flow Aug 25, 2023
BrunoQuaresma
BrunoQuaresma approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@aslilac aslilac merged commit ce9b048 into main Aug 28, 2023
@aslilac aslilac deleted the improved-template-publishing-flow branch August 28, 2023 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publishing a template in UI does return to the template UI and should provide a confirmation
2 participants
@aslilac @BrunoQuaresma