Skip to content

ci: Don't run PostgreSQL tests in parallel #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2022
Merged

ci: Don't run PostgreSQL tests in parallel #94

merged 1 commit into from
Jan 30, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jan 30, 2022

There have been race conditions when multiple instances
are created at once. This is an attempt to fix!

There's an ipv4 and ipv6 conflict that can occur in Docker. We'll reduce the Go test parallel count back to 1 until we get time to investigate. See: moby/moby#42442

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #94 (346dcbc) into main (5367d93) will decrease coverage by 6.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   78.30%   71.87%   -6.44%     
==========================================
  Files          51       89      +38     
  Lines         507     3612    +3105     
  Branches       55       55              
==========================================
+ Hits          397     2596    +2199     
- Misses         97      793     +696     
- Partials       13      223     +210     
Flag Coverage Δ
unittest-go-macos-latest 67.56% <ø> (?)
unittest-go-ubuntu-latest 70.08% <ø> (?)
unittest-go-windows-latest 67.46% <ø> (?)
unittest-js 78.30% <ø> (ø)
Impacted Files Coverage Δ
database/postgres/postgres.go 70.00% <0.00%> (ø)
codersdk/workspaces.go 73.95% <0.00%> (ø)
coderd/users.go 61.63% <0.00%> (ø)
codersdk/users.go 55.40% <0.00%> (ø)
database/pubsub.go 77.08% <0.00%> (ø)
coderd/cmd/root.go 85.71% <0.00%> (ø)
coderd/projects.go 67.32% <0.00%> (ø)
site/embed.go 72.31% <0.00%> (ø)
httpmw/workspaceparam.go 76.47% <0.00%> (ø)
httpmw/apikey.go 84.34% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5367d93...346dcbc. Read the comment docs.

Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing this out @kylecarbs !

There have been race conditions when multiple instances
are created at once. This is an attempt to fix!
@kylecarbs kylecarbs changed the title ci: Lock PostgreSQL database creation ci: Don't run PostgreSQL tests in parallel Jan 30, 2022
@kylecarbs kylecarbs merged commit a7d6f4b into main Jan 30, 2022
@kylecarbs kylecarbs deleted the pgonce branch January 30, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants