Skip to content

fix: hide OIDC and Github auth settings when they are disabled #9447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 30, 2023

Screenshot 2023-08-30 at 1 27 26 PM

Closes #9394

We were doing some...real weird stuff on this page before for disabled auth providers. They both communicate much more clearly now!

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@aslilac aslilac merged commit 4c91146 into main Aug 30, 2023
@aslilac aslilac deleted the cleanup-auth-settings branch August 30, 2023 21:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC page in Deployment is misleading.
2 participants