test: improve E2E framework #9469
Conversation
| @@ -4,7 +4,7 @@ import { STORAGE_STATE } from "./playwright.config" | |||
| import { Language } from "../src/components/CreateUserForm/CreateUserForm" | |||
|
|
|||
| test("create first user", async ({ page }) => { | |||
| await page.goto("/", { waitUntil: "networkidle" }) | |||
| await page.goto("/", { waitUntil: "domcontentloaded" }) | |||
There was a problem hiding this comment.
I don't think we should necessarily change networkidle to domcontentloaded without adding additional wait checks. For instance "wait until element X is present in the html". In a sense, networkidle should be better as it will wait longer compared to domcontentloaded which will fire immediately after dom even if network requests are still outbound.
There was a problem hiding this comment.
In previous PRs, I added extra "wait until" conditions, so in theory it should be faster and still safe with domcontentloaded.
| @@ -28,13 +33,13 @@ test("web terminal", async ({ context, page }) => { | |||
| ], | |||
| }) | |||
| await createWorkspace(page, template) | |||
| await startAgent(page, token) | |||
| const agent = await startAgent(page, token) | |||
There was a problem hiding this comment.
We still have the unfortunate problem that any error in a test will terminate execution and the agent won't be cleaned up. Can we somehow make it a post-test cleanup hook that always runs and checks if an agent is running?
This isn't a big problem per-se but can cause trouble when running locally -> suddenly all tests fail after one failure. And also cause noise in test output.
There was a problem hiding this comment.
I was trying to implement an easy way but failed. The clue is to pass the PID of the process/group of process to the test.afterEach. Something like "clean used resources", but not necessarily re-discover them.
This PR tweaks e2e tests to make bug investigation easier in the future.
Changes:
pprofdumps as Github Action artifacts with custom reporternetworkidlein testsstopAgentwithpkillorkillpproffor the web server (coder server)