Skip to content

refactor(enterprise/cli): remove provisionerd from slim binary #9488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2023
Merged

refactor(enterprise/cli): remove provisionerd from slim binary #9488

merged 1 commit into from
Sep 1, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Sep 1, 2023

This change saves 8 MB in the slim binary.

Ref: #9380

❯ ls -lha build
total 2.0G
drwxr-xr-x  2 coder coder 4.0K Sep  1 17:28 ./
drwxr-xr-x 30 coder coder 4.0K Sep  1 17:23 ../
-rw-r--r--  1 coder coder 300M Sep  1 17:26 coder-slim_2.1.4-devel+5524374ef.tar
-rw-r--r--  1 coder coder  79M Sep  1 17:26 coder-slim_2.1.4-devel+5524374ef.tar.zst
-rw-r--r--  1 coder coder  434 Sep  1 17:26 coder-slim_2.1.4-devel+5524374ef_checksums.sha1
-rwxr-xr-x  1 coder coder  46M Sep  1 17:25 coder-slim_2.1.4-devel+5524374ef_darwin_amd64*
-rwxr-xr-x  1 coder coder  46M Sep  1 17:25 coder-slim_2.1.4-devel+5524374ef_darwin_arm64*
-rwxr-xr-x  1 coder coder  44M Sep  1 17:24 coder-slim_2.1.4-devel+5524374ef_linux_amd64*
-rwxr-xr-x  1 coder coder  42M Sep  1 17:24 coder-slim_2.1.4-devel+5524374ef_linux_arm64*
-rwxr-xr-x  1 coder coder  41M Sep  1 17:25 coder-slim_2.1.4-devel+5524374ef_linux_armv7*
-rwxr-xr-x  1 coder coder  43M Sep  1 17:26 coder-slim_2.1.4-devel+5524374ef_windows_amd64.exe*
-rwxr-xr-x  1 coder coder  41M Sep  1 17:26 coder-slim_2.1.4-devel+5524374ef_windows_arm64.exe*
-rwxr-xr-x  1 coder coder 199M Sep  1 17:27 coder_2.1.4-devel+5524374ef_darwin_amd64*
-rwxr-xr-x  1 coder coder 199M Sep  1 17:27 coder_2.1.4-devel+5524374ef_darwin_arm64*
-rwxr-xr-x  1 coder coder 193M Sep  1 17:26 coder_2.1.4-devel+5524374ef_linux_amd64*
-rwxr-xr-x  1 coder coder 190M Sep  1 17:27 coder_2.1.4-devel+5524374ef_linux_arm64*
-rwxr-xr-x  1 coder coder 188M Sep  1 17:27 coder_2.1.4-devel+5524374ef_linux_armv7*
-rwxr-xr-x  1 coder coder 193M Sep  1 17:28 coder_2.1.4-devel+5524374ef_windows_amd64.exe*
-rwxr-xr-x  1 coder coder 189M Sep  1 17:28 coder_2.1.4-devel+5524374ef_windows_arm64.exe*

Assuming this doesn't break any workflows or use-cases, it would be a worthwhile change.

@mafredri
refactor(enterprise/cli): remove provisionerd from slim binary
be22f25 
This change saves 8 MB in the slim binary.

Ref: #9380
@mafredri mafredri self-assigned this Sep 1, 2023
@mafredri mafredri enabled auto-merge (squash) September 1, 2023 18:25
@mafredri mafredri merged commit 27ab0d9 into main Sep 1, 2023
@mafredri mafredri deleted the mafredri/refactor-ent-cli-remove-provisionerd-from-slim branch September 1, 2023 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@Emyrk Emyrk Awaiting requested review from Emyrk

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @kylecarbs