Skip to content

refactor(cli): use codersdk for provisioner types #9508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2023
Merged

refactor(cli): use codersdk for provisioner types #9508

merged 2 commits into from
Sep 4, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Sep 4, 2023

This change removes one use of coderd/database from the slim binary
and more correctly uses codersdk instead of database or provisionerd
packages.

No size change (yet).

Ref: #9380

@mafredri
refactor(cli): use codersdk for provisioner types
eeeebbb 
This change removes one use of `coderd/database` from the slim binary
and more correctly uses codersdk instead of database or provisionerd
packages.

No size change (yet).

Ref: #9380
@mafredri mafredri self-assigned this Sep 4, 2023
@mafredri mafredri mentioned this pull request Sep 4, 2023
Closed
mafredri added a commit that referenced this pull request Sep 4, 2023
@mafredri
refactor(coderd/database): generate dbresetpw with queries for reset-…
0a61ba8 
…password command

This change removes 1 MB from the slim binary, and combined with the
following PRs: #9481, #9506, #9508, #9517, a total of 4 MB.

Ref: #9380
@mafredri mafredri mentioned this pull request Sep 4, 2023
Merged
mafredri added a commit that referenced this pull request Sep 4, 2023
@mafredri
refactor(cli)!: remove reset-password from slim binary
9c959e6 
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
mafredri added a commit that referenced this pull request Sep 4, 2023
@mafredri
refactor(cli)!: remove reset-password from slim binary (#9520)
d211594 
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
@mafredri mafredri merged commit b240799 into main Sep 4, 2023
@mafredri mafredri deleted the mafredri/refactor-provisioner-type branch September 4, 2023 18:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @kylecarbs