Skip to content

refactor(cli)!: remove reset-password from slim binary #9520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2023
Merged

refactor(cli)!: remove reset-password from slim binary #9520

merged 1 commit into from
Sep 4, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Sep 4, 2023

This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380

❯ ls -lh build
-rwxr-xr-x 1 coder coder 44M Sep  4 16:12 coder-slim_2.1.4-devel+ad23d33f2_linux_amd64*
-rwxr-xr-x 1 coder coder 42M Sep  4 16:12 coder-slim_2.1.4-devel+ef51f8dcf_linux_amd64*
-rwxr-xr-x 2 coder coder 39M Sep  4 16:12 coder-slim_2.1.4-devel+17960ddc7_linux_amd64*

@mafredri
refactor(cli)!: remove reset-password from slim binary
9c959e6 
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
@mafredri mafredri self-assigned this Sep 4, 2023
@github-actions github-actions bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Sep 4, 2023
@mafredri mafredri mentioned this pull request Sep 4, 2023
Closed
@mafredri mafredri merged commit d211594 into main Sep 4, 2023
@mafredri mafredri deleted the mafredri/refactor-remove-resetpw-from-slim branch September 4, 2023 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mafredri mafredri

Labels
release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @johnstcn @kylecarbs