Skip to content

refactor: improve flag interpretation for install.sh #9554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Sep 6, 2023

  • Make some smarter decisions about installation method based on what flags are being given
  • Detect PATH conflicts when installing via Homebrew or standalone
  • Add a section to our documentation about dealing with PATH conflicts

I may have gone a little overboard with this one 😝

@aslilac aslilac requested a review from matifali September 6, 2023 18:11
@aslilac aslilac changed the title refactor: better flag interpretation for install.sh refactor: improve flag interpretation for install.sh Sep 6, 2023
@aslilac aslilac merged commit 4ed8dd0 into main Sep 6, 2023
@aslilac aslilac deleted the install-sh-fixes branch September 6, 2023 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants