chore(site): refactor stories and test from page components #9603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BrunoQuaresma
commented
Sep 8, 2023
- Update Storybook usage to use v7 API
- Remove render tests from integration tests and move them to stories
68d7833 to
2f55e6b
Compare
aslilac
approved these changes
Sep 8, 2023
Comment on lines
+14
to
+22
| children: [ | ||
| <Cond key="1" condition> | ||
| The first one shows. | ||
| </Cond>, | ||
| <Cond key="2" condition={false}> | ||
| The second one does not show. | ||
| </Cond>, | ||
| <Cond key="3">The default does not show.</Cond>, | ||
| ], |
There was a problem hiding this comment.
I liked the earlier commit where these were fragments: React will perform better with those. Does it break the ChooseOne component or something?
There was a problem hiding this comment.
Nops, it is just for the storybook. I didnt find a similar API to keep it as a fragment in the new Storybook v7 API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.