Skip to content

chore: support external types in typescript codegen #9633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 12, 2023
Merged

chore: support external types in typescript codegen #9633

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e42e170
chore: support external types in typescript codegen
Emyrk Sep 11, 2023
2744539
fix enums on external packages
Emyrk Sep 11, 2023
02237b7
Support clibase.struct
Emyrk Sep 11, 2023
ad74acb
Add regexp
Emyrk Sep 11, 2023
e17f95e
Make gen with updated generator
Emyrk Sep 11, 2023
4a56fe1
Import order
Emyrk Sep 12, 2023
a99ddf7
Merge remote-tracking branch 'origin/main' into stevenmasley/optionse…
Emyrk Sep 12, 2023
027ff1a
Make gen
Emyrk Sep 12, 2023
a9ee431
Fix TS issues
Emyrk Sep 12, 2023
e04ee52
Linting
Emyrk Sep 12, 2023
f84795f
Linting
Emyrk Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix TS issues
  • Loading branch information
@Emyrk
Emyrk committed Sep 12, 2023
commit a9ee4319b4b4c2f78be7d490f728f13c589d9fd8
9 changes: 9 additions & 0 deletions site/src/pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPageView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@ const meta: Meta<typeof GitAuthSettingsPageView> = {
type: "GitHub",
client_id: "client_id",
regex: "regex",
auth_url: "",
token_url: "",
validate_url: "",
app_install_url: "https://github.com/apps/coder/installations/new",
app_installations_url: "",
no_refresh: false,
scopes: [],
device_flow: true,
device_code_url: "",
},
],
},
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const GitAuthSettingsPageView = ({
</TableRow>
</TableHead>
<TableBody>
{((config.git_auth === null || config.git_auth.length === 0) && (
{((config.git_auth === null || config.git_auth?.length === 0) && (
<TableRow>
<TableCell colSpan={999}>
<div className={styles.empty}>
Expand All @@ -65,7 +65,7 @@ export const GitAuthSettingsPageView = ({
</TableCell>
</TableRow>
)) ||
config.git_auth.map((git: GitAuthConfig) => {
config.git_auth?.map((git: GitAuthConfig) => {
const name = git.id || git.type;
return (
<TableRow key={name}>
Expand Down