Skip to content

chore: support external types in typescript codegen #9633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 12, 2023
Merged

chore: support external types in typescript codegen #9633

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e42e170
chore: support external types in typescript codegen
Emyrk Sep 11, 2023
2744539
fix enums on external packages
Emyrk Sep 11, 2023
02237b7
Support clibase.struct
Emyrk Sep 11, 2023
ad74acb
Add regexp
Emyrk Sep 11, 2023
e17f95e
Make gen with updated generator
Emyrk Sep 11, 2023
4a56fe1
Import order
Emyrk Sep 12, 2023
a99ddf7
Merge remote-tracking branch 'origin/main' into stevenmasley/optionse…
Emyrk Sep 12, 2023
027ff1a
Make gen
Emyrk Sep 12, 2023
a9ee431
Fix TS issues
Emyrk Sep 12, 2023
e04ee52
Linting
Emyrk Sep 12, 2023
f84795f
Linting
Emyrk Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add regexp
  • Loading branch information
@Emyrk
Emyrk committed Sep 11, 2023
commit ad74acbdb8eb6e0593c107a9a405c29cd1305bf9
2 changes: 2 additions & 0 deletions scripts/apitypings/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,6 +830,8 @@ func (g *Generator) typescriptType(ty types.Type) (TypescriptType, error) {
// We would need to add more logic to determine this, but for now
// just hard code them.
switch n.String() {
case "github.com/coder/coder/v2/cli/clibase.Regexp":
return TypescriptType{ValueType: "string"}, nil
case "github.com/coder/coder/v2/cli/clibase.HostPort":
// Custom marshal json to be a string
return TypescriptType{ValueType: "string"}, nil
Expand Down