Minor fixes

coder · BrunoQuaresma · Sep 14, 2023 · Sep 11, 2023 · Sep 11, 2023 · Sep 11, 2023
commit 16c08b8e243b03226777d7940bd2cfc9c5564811
diff --git a/site/src/components/RequireAuth/RequireAuth.tsx b/site/src/components/RequireAuth/RequireAuth.tsx
@@ -6,6 +6,7 @@ import { embedRedirect } from "../../utils/redirect";
 import { FullScreenLoader } from "../Loader/FullScreenLoader";
 import { DashboardProvider } from "components/Dashboard/DashboardProvider";
 import { ProxyProvider } from "contexts/ProxyContext";
+import { isApiError } from "api/errors";
 
 export const RequireAuth: FC = () => {
   const [authState, authSend] = useAuth();
@@ -18,12 +19,13 @@ export const RequireAuth: FC = () => {
   useEffect(() => {
     const interceptorHandle = axios.interceptors.response.use(
       (okResponse) => okResponse,
-      (error) => {
+      (error: unknown) => {
         // 401 Unauthorized
         // If we encountered an authentication error, then our token is probably
         // invalid and we should update the auth state to reflect that.
-        if (error.response.status === 401) {
+        if (isApiError(error) && error.response.status === 401) {
           authSend("SIGN_OUT");
+          return;
         }
 
         // Otherwise, pass the response through so that it can be displayed in the UI

diff --git a/site/src/utils/metadata.ts b/site/src/utils/metadata.ts
@@ -8,7 +8,11 @@ export const getMetadataAsJSON = <T extends Record<string, any>>(
     try {
       return JSON.parse(rawContent as string);
     } catch (ex) {
-      throw new Error(`Failed to parse ${property} metadata`);
+      // In development the metadata is always going to be empty throwing this
+      // error
+      if (process.env.NODE_ENV === "production") {
+        console.warn(`Failed to parse ${property} metadata`);
+      }
     }
   }
 };