Skip to content

chore(site): migrate a few services to react-query used in the DashboardProvider #9667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Migrate experiments to react-query
  • Loading branch information
BrunoQuaresma committed Sep 13, 2023
commit 4ec38be23da3d3e19cb730a48bf31e2a6ae6470a
23 changes: 23 additions & 0 deletions site/src/api/queries/experiments.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import * as API from "api/api";

export const experiments = () => {
return {
queryKey: ["experiments"],
queryFn: fetchExperiments,
};
};

const fetchExperiments = async () => {
// Experiments is injected by the Coder server into the HTML document.
const experiments = document.querySelector("meta[property=experiments]");
if (experiments) {
const rawContent = experiments.getAttribute("content");
try {
return JSON.parse(rawContent as string);
} catch (ex) {
// Ignore this and fetch as normal!
}
}

return API.getExperiments();
};
9 changes: 4 additions & 5 deletions site/src/components/Dashboard/DashboardProvider.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { useQuery } from "@tanstack/react-query";
import { useMachine } from "@xstate/react";
import { buildInfo } from "api/queries/buildInfo";
import { experiments } from "api/queries/experiments";
import { entitlements } from "api/queries/entitlements";
import {
AppearanceConfig,
Expand All @@ -11,7 +12,6 @@ import {
import { FullScreenLoader } from "components/Loader/FullScreenLoader";
import { createContext, FC, PropsWithChildren, useContext } from "react";
import { appearanceMachine } from "xServices/appearance/appearanceXService";
import { experimentsMachine } from "xServices/experiments/experimentsMachine";

interface Appearance {
config: AppearanceConfig;
Expand All @@ -34,15 +34,14 @@ export const DashboardProviderContext = createContext<
export const DashboardProvider: FC<PropsWithChildren> = ({ children }) => {
const buildInfoQuery = useQuery(buildInfo());
const entitlementsQuery = useQuery(entitlements());
const experimentsQuery = useQuery(experiments());
const [appearanceState, appearanceSend] = useMachine(appearanceMachine);
const [experimentsState] = useMachine(experimentsMachine);
const { appearance, preview } = appearanceState.context;
const { experiments } = experimentsState.context;
const isLoading =
!buildInfoQuery.data ||
!entitlementsQuery.data ||
!appearance ||
!experiments;
!experimentsQuery.data;

const setAppearancePreview = (config: AppearanceConfig) => {
appearanceSend({
Expand All @@ -67,7 +66,7 @@ export const DashboardProvider: FC<PropsWithChildren> = ({ children }) => {
value={{
buildInfo: buildInfoQuery.data,
entitlements: entitlementsQuery.data,
experiments,
experiments: experimentsQuery.data,
appearance: {
preview,
config: appearance,
Expand Down
87 changes: 0 additions & 87 deletions site/src/xServices/experiments/experimentsMachine.ts

This file was deleted.