Skip to content

fix: make agent ssh session env var case insensitive #9675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: make agent ssh session env var case insensitive #9675

merged 1 commit into from
Sep 13, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Sep 13, 2023

Fixes #9673

I force the constants to lowercase too, even though they already are. Just incase someone messes with them...

Really wish there was case insensitive "switch" statement in go.

@Emyrk Emyrk changed the title fix: case insensitve agent ssh session env var fix: make agent ssh session env var case insensitive Sep 13, 2023
@github-actions
Copy link

github-actions bot commented Sep 13, 2023 •
edited
Loading

✔️ PR 9675 Created successfully.
🚀 Access the credentials here.

cc: @Emyrk

@Emyrk Emyrk merged commit e0e6d7c into main Sep 13, 2023
@Emyrk Emyrk deleted the stevenmasley/jetbrains_ssh_count branch September 13, 2023 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: /api/v2/deployment/stats does not return count for JetBrains Gateway sessions
2 participants
@Emyrk @kylecarbs