fix(cli): display pasted session token #9710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
previously approved these changes
Sep 20, 2023
|
Seems like this doesn't fix it on Windows :( |
johnstcn
reviewed
Sep 20, 2023
Comment on lines
+174
to
+177
| if runtime.GOOS != "windows" { | ||
| // For some reason, the match does not show up on Windows. | ||
| pty.ExpectMatch(client.SessionToken()) | ||
| } |
There was a problem hiding this comment.
Manually validated that this works on Windows, just appears to be a weird feature of ptytest. Disabling the session token echo check on Windows for now.
mafredri
approved these changes
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR addresses the
coder loginflow, and displays the session token when pasted into the terminal (this was the behavior in Coder v1). this change is due to feedback from one of our largest customers:customer issue: https://github.com/coder/customers/issues/287