Skip to content

refactor(site): do not display error details as message #9755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix #6983

We don't want to show "code" related errors to the user so I'm returning the default error message when the error is not an API error.

@BrunoQuaresma BrunoQuaresma requested a review from a team September 18, 2023 16:34
@BrunoQuaresma BrunoQuaresma self-assigned this Sep 18, 2023
@BrunoQuaresma BrunoQuaresma requested review from Parkreiner and removed request for a team September 18, 2023 16:34
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense to me.

@BrunoQuaresma BrunoQuaresma merged commit 7bc98c2 into main Sep 19, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/show-better-error branch September 19, 2023 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants