Skip to content

refactor(site): do not display error details as message #9755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2023
Merged

refactor(site): do not display error details as message #9755

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59745af
refactor(site): do not display error details as message
BrunoQuaresma Sep 18, 2023
45273dd
Improve login auth error
BrunoQuaresma Sep 19, 2023
a50fc50
Merge branch 'main' of https://github.com/coder/coder into bq/show-be…
BrunoQuaresma Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions site/src/api/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,7 @@ export const mapApiErrorToFieldErrors = (
export const getErrorMessage = (
error: unknown,
defaultMessage: string,
): string =>
isApiError(error)
? error.response.data.message
: error instanceof Error
? error.message
: defaultMessage;
): string => (isApiError(error) ? error.response.data.message : defaultMessage);

/**
*
Expand Down