fix: add localStorage to useWorkspacesFilter

coder · Parkreiner · Sep 20, 2023 · Sep 18, 2023 · Sep 18, 2023 · Sep 18, 2023
commit 553ce890f7c38080fae044263cdabeac99eef310
diff --git a/site/src/pages/WorkspacesPage/WorkspacesPage.tsx b/site/src/pages/WorkspacesPage/WorkspacesPage.tsx
@@ -126,14 +126,27 @@ type UseWorkspacesFilterOptions = {
   pagination: ReturnType<typeof usePagination>;
 };
 
+const filterPreferencesKey = "WorkspacesPage/filterPreferences";
+
 const useWorkspacesFilter = ({
   searchParamsResult,
   pagination,
 }: UseWorkspacesFilterOptions) => {
   const filter = useFilter({
-    initialValue: `owner:me`,
     searchParamsResult,
-    onUpdate: () => {
+    initialValue: () => {
+      const fallbackValue = "owner:me";
+
+      // Have to include check because initialValue will be called during the
+      // render itself; future-proofing for SSR, if we ever need that
+      if (typeof window === "undefined") {
+        return fallbackValue;
+      }
+
+      return window.localStorage.getItem(filterPreferencesKey) ?? fallbackValue;
+    },
+    onUpdate: (newValues) => {
+      window.localStorage.setItem(filterPreferencesKey, newValues);
       pagination.goToPage(1);
     },
   });