chore: Rename initialValue to fallbackFilter

coder · Parkreiner · Sep 20, 2023 · Sep 18, 2023 · Sep 18, 2023 · Sep 18, 2023
commit ab9de0cc31bf8d45bf325e8f70dae6269c9bb806
diff --git a/site/src/components/Filter/filter.tsx b/site/src/components/Filter/filter.tsx
@@ -36,18 +36,19 @@ type FilterValues = Record<string, string | undefined>;
 
 type UseFilterConfig = {
   /**
-   * The fallback value to use in the event that no filter params can be used.
-   * This value is allowed to change on re-renders.
+   * The fallback value to use in the event that no filter params can be parsed
+   * from the search params object. This value is allowed to change on
+   * re-renders.
    */
-  initialValue?: string;
+  fallbackFilter?: string;
   searchParamsResult: ReturnType<typeof useSearchParams>;
   onUpdate?: (newValue: string) => void;
 };
 
 const useFilterParamsKey = "filter";
 
 export const useFilter = ({
-  initialValue: fallbackFilter = "",
+  fallbackFilter = "",
   searchParamsResult,
   onUpdate,
 }: UseFilterConfig) => {

diff --git a/site/src/pages/WorkspacesPage/WorkspacesPage.tsx b/site/src/pages/WorkspacesPage/WorkspacesPage.tsx
@@ -190,7 +190,7 @@ const useWorkspacesFilter = ({
     /**
      * @todo Rename initialValue to fallbackFilter once changes have been tested
      */
-    initialValue: localStorageFilter,
+    fallbackFilter: localStorageFilter,
     searchParamsResult,
     onUpdate: (newValues) => {
       window.localStorage.setItem(workspaceFilterKey, newValues);