Skip to content

fix: Multiple builds using the incorrect agent token #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2022
Merged

fix: Multiple builds using the incorrect agent token #983

merged 2 commits into from
Apr 12, 2022

Conversation

kylecarbs
Copy link
Member

This was an issue with our in-memory database that caused
newer builds to return an outdated agent, which would then
be rejected.

A test case has been added to ensure this can't happen again!

@kylecarbs kylecarbs requested a review from f0ssel April 12, 2022 18:12
@kylecarbs kylecarbs self-assigned this Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #983 (bede39d) into main (e8b3101) will increase coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #983      +/-   ##
==========================================
+ Coverage   66.47%   66.78%   +0.30%     
==========================================
  Files         240      237       -3     
  Lines       14588    14404     -184     
  Branches      115      115              
==========================================
- Hits         9698     9619      -79     
+ Misses       3897     3827      -70     
+ Partials      993      958      -35
Flag Coverage Δ
unittest-go-macos-latest 53.60% <ø> (+0.12%) ⬆️
unittest-go-postgres- 66.52% <ø> (+0.29%) ⬆️
unittest-go-ubuntu-latest 56.25% <ø> (+0.18%) ⬆️
unittest-go-windows-2022 ?
unittest-js 61.56% <ø> (ø)
Impacted Files Coverage Δ
cli/configssh.go 61.41% <0.00%> (-7.09%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
peer/channel.go 83.23% <0.00%> (-1.74%) ⬇️
agent/usershell/usershell_windows.go
pty/pty_windows.go
pty/start_windows.go
coderd/database/queries.sql.go 83.86% <0.00%> (+0.20%) ⬆️
provisioner/terraform/provision.go 68.54% <0.00%> (+0.43%) ⬆️
peer/conn.go 80.71% <0.00%> (+2.03%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b3101...bede39d. Read the comment docs.

@kylecarbs
fix: Multiple builds using the incorrect agent token
96b068b 
This was an issue with our in-memory database that caused
newer builds to return an outdated agent, which would then
be rejected.

A test case has been added to ensure this can't happen again!
@kylecarbs kylecarbs enabled auto-merge (squash) April 12, 2022 19:38
@kylecarbs kylecarbs merged commit e345827 into main Apr 12, 2022
@kylecarbs kylecarbs deleted the multibuild branch April 12, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0ssel f0ssel f0ssel approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @f0ssel