chore: set sessionAffinity to None in helm chart #9918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that helm works out-of-the-box on AWS.
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
deansheather
approved these changes
Sep 29, 2023
|
@deansheather — curious if you know why it was ClientIP at first? Was there a performance issue we were solving? |
@ammario ClientIP avoids cases where requests to the same app will hit every single coder replica and cause each replica to have to stand up a connection to the workspace for the first time. It gets worse the more replicas you have |
|
Ok. I do remember being that a problem in v1. I'll merge this now as I think the getting started experience not erroring on AWS is slightly more important. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.