Skip to content

fix(cli): remove exp scaletest from slim binary #9934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 3, 2023
Merged

fix(cli): remove exp scaletest from slim binary #9934

merged 8 commits into from
Oct 3, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Sep 29, 2023 •
edited
Loading

#9927 (comment)

These new imports add 5MB to the slim binary

@johnstcn johnstcn self-assigned this Sep 29, 2023
@johnstcn johnstcn mentioned this pull request Sep 29, 2023
Merged
mafredri
mafredri approved these changes Oct 2, 2023
View reviewed changes
@johnstcn johnstcn force-pushed the cj/exp-scaletest-not-slim branch from 4304425 to ead423e Compare October 3, 2023 10:50
@johnstcn johnstcn marked this pull request as ready for review October 3, 2023 11:51
@johnstcn johnstcn requested a review from mafredri October 3, 2023 11:51
@johnstcn johnstcn requested a review from mtojek October 3, 2023 12:43
mtojek
mtojek approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnstcn johnstcn merged commit 9aac152 into main Oct 3, 2023
@johnstcn johnstcn deleted the cj/exp-scaletest-not-slim branch October 3, 2023 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @mafredri @mtojek