Skip to content

feat: allow external services to be authable #9996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 3, 2023
Merged

feat: allow external services to be authable #9996

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a2ccfb0
feat: allow external services to be authable
kylecarbs Sep 30, 2023
614313b
Refactor external auth config structure for defaults
kylecarbs Oct 2, 2023
c4b0fa0
Add support for new config properties
kylecarbs Oct 2, 2023
e6c047c
Change the name of external auth
kylecarbs Oct 2, 2023
9ad24b6
Move externalauth -> external-auth
kylecarbs Oct 2, 2023
7937b0e
Run gen
kylecarbs Oct 2, 2023
ec7a7a0
Fix tests
kylecarbs Oct 2, 2023
c4a3dba
Fix MW tests
kylecarbs Oct 2, 2023
c4931b6
Fix git auth redirect
kylecarbs Oct 2, 2023
dbb1471
Fix lint
kylecarbs Oct 2, 2023
4fbc086
Fix name
kylecarbs Oct 2, 2023
02718dd
Allow any ID
kylecarbs Oct 2, 2023
6d75621
Fix invalid type test
kylecarbs Oct 2, 2023
291e61e
Fix e2e tests
kylecarbs Oct 2, 2023
386dc9c
Fix comments
kylecarbs Oct 2, 2023
0b409f3
Fix colors
kylecarbs Oct 2, 2023
0fd1f7a
Allow accepting any type as string
kylecarbs Oct 2, 2023
c1c4786
Run gen
kylecarbs Oct 2, 2023
edea1da
Merge branch 'main' into extauthprovider
kylecarbs Oct 2, 2023
0acc3a7
Fix href
kylecarbs Oct 2, 2023
4a101ea
Merge branch 'main' into extauthprovider
kylecarbs Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix href
  • Loading branch information
@kylecarbs
kylecarbs committed Oct 2, 2023
commit 0acc3a749245c77e1843d5eacb6ff6ba4dfea78a
5 changes: 2 additions & 3 deletions site/src/pages/ExternalAuthPage/ExternalAuthPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
} from "api/api";
import { usePermissions } from "hooks";
import { type FC } from "react";
import { useNavigate, useParams } from "react-router-dom";
import { useParams } from "react-router-dom";
import ExternalAuthPageView from "./ExternalAuthPageView";
import { ApiErrorResponse } from "api/errors";
import { isAxiosError } from "axios";
Expand All @@ -16,7 +16,6 @@ const ExternalAuthPage: FC = () => {
if (!provider) {
throw new Error("provider must exist");
}
const navigate = useNavigate();
const permissions = usePermissions();
const queryClient = useQueryClient();
const getExternalAuthProviderQuery = useQuery({
Expand Down Expand Up @@ -73,7 +72,7 @@ const ExternalAuthPage: FC = () => {
!getExternalAuthProviderQuery.data.authenticated &&
!getExternalAuthProviderQuery.data.device
) {
navigate(`/external-auth/${provider}/callback`);
window.location.href = `/external-auth/${provider}/callback`;
return null;
}

Expand Down