Fix lint

coder · kylecarbs · Oct 3, 2023 · Sep 30, 2023 · Oct 2, 2023 · Oct 2, 2023
commit dbb1471309573a261784c2d67b1ce8051f04973d
diff --git a/cli/server.go b/cli/server.go
@@ -2167,22 +2167,22 @@ func ConfigureHTTPServers(inv *clibase.Invocation, cfg *codersdk.DeploymentValue
 // ReadExternalAuthProvidersFromEnv is provided for compatibility purposes with
 // the viper CLI.
 func ReadExternalAuthProvidersFromEnv(environ []string) ([]codersdk.ExternalAuthConfig, error) {
-	providers, err := readExternalAuthProvidersFromEnv("CODER_EXTERNAL_AUTH_", environ)
+	providers, err := parseExternalAuthProvidersFromEnv("CODER_EXTERNAL_AUTH_", environ)
 	if err != nil {
 		return nil, err
 	}
 	// Deprecated: To support legacy git auth!
-	gitProviders, err := readExternalAuthProvidersFromEnv("CODER_GITAUTH_", environ)
+	gitProviders, err := parseExternalAuthProvidersFromEnv("CODER_GITAUTH_", environ)
 	if err != nil {
 		return nil, err
 	}
 	return append(providers, gitProviders...), nil
 }
 
-// readExternalAuthProvidersFromEnv consumes environment variables to parse
+// parseExternalAuthProvidersFromEnv consumes environment variables to parse
 // external auth providers. A prefix is provided to support the legacy
 // parsing of `GITAUTH` environment variables.
-func readExternalAuthProvidersFromEnv(prefix string, environ []string) ([]codersdk.ExternalAuthConfig, error) {
+func parseExternalAuthProvidersFromEnv(prefix string, environ []string) ([]codersdk.ExternalAuthConfig, error) {
 	// The index numbers must be in-order.
 	sort.Strings(environ)
 

diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/externalauth/externalauth.go b/coderd/externalauth/externalauth.go
@@ -366,6 +366,8 @@ func ConvertConfig(entries []codersdk.ExternalAuthConfig, accessURL *url.URL) ([
 	ids := map[string]struct{}{}
 	configs := []*Config{}
 	for _, entry := range entries {
+		entry := entry
+
 		var typ codersdk.ExternalAuthProvider
 		switch codersdk.ExternalAuthProvider(entry.Type) {
 		case codersdk.ExternalAuthProviderOpenIDConnect:

diff --git a/site/src/api/api.ts b/site/src/api/api.ts
@@ -873,7 +873,10 @@ export const exchangeExternalAuthDevice = async (
   provider: string,
   req: TypesGen.ExternalAuthDeviceExchange,
 ): Promise<void> => {
-  const resp = await axios.post(`/api/v2/external-auth/${provider}/device`, req);
+  const resp = await axios.post(
+    `/api/v2/external-auth/${provider}/device`,
+    req,
+  );
   return resp.data;
 };