Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

fix: ensure error chan is buffered in (*Dialer).negotiate #437

Merged
merged 4 commits into from
Sep 9, 2021
Merged

fix: ensure error chan is buffered in (*Dialer).negotiate #437

merged 4 commits into from
Sep 9, 2021

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Sep 9, 2021

No description provided.

@coadler coadler requested a review from deansheather September 9, 2021 23:38
@coadler coadler self-assigned this Sep 9, 2021
@coveralls
Copy link

coveralls commented Sep 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1219341283

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 47.88%
Files with Coverage Reduction New Missed Lines %
wsnet/dial.go 4 76.83%
Totals Coverage Status
Change from base Build 1219077143: -0.06%
Covered Lines: 2800
Relevant Lines: 5848
💛 - Coveralls

@coadler coadler merged commit 4c89550 into main Sep 9, 2021
@coadler coadler deleted the colin/wsep-dialer-unbuffered-chan branch September 9, 2021 23:54
deansheather pushed a commit that referenced this pull request Sep 10, 2021
@coadler @deansheather
fix: ensure error chan is buffered in (*Dialer).negotiate (#437)
cb15635 
(cherry picked from commit 4c89550)
deansheather pushed a commit that referenced this pull request Sep 13, 2021
@coadler @deansheather
fix: ensure error chan is buffered in (*Dialer).negotiate (#437)
2954cab 
(cherry picked from commit 4c89550)
(cherry picked from commit cb15635)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @coveralls @deansheather