-
Notifications
You must be signed in to change notification settings - Fork 643
Containers: Add VS Code tasks and improve overall documentation & flexibility #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dockerfile
Outdated
# Fix permissions for code-server | ||
RUN sudo chown -R coder:coder /home/coder/.local | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes the install extension example work
| Variable Name | Description | Default Value | | ||
| ----------------- | ------------------------------------------------------------------------------------------------ | ------------------- | | ||
| `PASSWORD` | Password for code-server | | | ||
| `HASHED_PASSWORD` | Overrrides PASSWORD. [SHA-256 hash](https://xorbin.com/tools/sha256-hash-calculator) of password | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added hashed password :)
|
||
# In VS Code: | ||
# ctrl + P, run task: push_remote or pull_remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
documented the new tasks
"problemMatcher": [], | ||
"options": { | ||
"statusbar": { | ||
"label": "$(repo-push) rclone: push" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i slightly modified the labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AurangAsif would love your thoughts
Looks good! Even though |
I can disable this but what is the use case? It will only pull if there are existing files in the rclone remote. Should I also make a setting so that it doesn't push the files by default? |
I've noticed pulling from rclone after starting code-server is much faster. Not sure why but it may just be my case. |
Just added the flags and the disable push/pull vars and documented. Thanks for the help! |
Thanks to @AurangAsif for the feedback on this and creating the VS Code tasks 🎉 see #8