Skip to content

Containers: Add VS Code tasks and improve overall documentation & flexibility #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 15, 2021

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Mar 15, 2021

Thanks to @AurangAsif for the feedback on this and creating the VS Code tasks 🎉 see #8

  • START_DIR can now be specified
  • add VS Code tasks for rclone!
  • document HASHED_PASSWORD
  • fix install extension instructions in Dockerfile

@bpmct bpmct changed the title Add Containers: Add VS Code tasks and improve overall documentation & flexibility Mar 15, 2021
@bpmct bpmct mentioned this pull request Mar 15, 2021
Dockerfile Outdated
Comment on lines 19 to 21
# Fix permissions for code-server
RUN sudo chown -R coder:coder /home/coder/.local

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes the install extension example work

| Variable Name | Description | Default Value |
| ----------------- | ------------------------------------------------------------------------------------------------ | ------------------- |
| `PASSWORD` | Password for code-server | |
| `HASHED_PASSWORD` | Overrrides PASSWORD. [SHA-256 hash](https://xorbin.com/tools/sha256-hash-calculator) of password |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added hashed password :)

Comment on lines +60 to +62

# In VS Code:
# ctrl + P, run task: push_remote or pull_remote
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documented the new tasks

"problemMatcher": [],
"options": {
"statusbar": {
"label": "$(repo-push) rclone: push"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i slightly modified the labels

Copy link
Member Author

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AurangAsif would love your thoughts

@ghost
Copy link

ghost commented Mar 15, 2021

Looks good! Even though HASHED_PASSWORD is now documented, I think documenting the CODE_SERVER_CONFIG variable which specifies the path to the config file would still help. It would also be useful if the user could disable the automatic pull from rclone at startup.

@bpmct
Copy link
Member Author

bpmct commented Mar 15, 2021

It would also be useful if the user could disable the automatic pull from rclone at startup.

I can disable this but what is the use case? It will only pull if there are existing files in the rclone remote. Should I also make a setting so that it doesn't push the files by default?

@ghost
Copy link

ghost commented Mar 15, 2021

I've noticed pulling from rclone after starting code-server is much faster. Not sure why but it may just be my case.
Having the option to not push automatically would be nice but it's also fine without it. One thing to note is maybe documenting how to change the push and pull remote .sh files to pass in flags to rclone sync. I have been using the exclude flag to stop some files from being pushed and its really handy.

@bpmct
Copy link
Member Author

bpmct commented Mar 15, 2021

Just added the flags and the disable push/pull vars and documented. Thanks for the help!

@bpmct bpmct merged commit 250971e into coder:main Mar 15, 2021
@bpmct bpmct deleted the aurang-fixes branch March 15, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant