-
Notifications
You must be signed in to change notification settings - Fork 82
chore: add CODER_RUNTIME var to docs #410
Conversation
Co-authored-by: Katie Horne <katie@coder.com>
* chore: Add solution for Docker problems Co-authored-by: Katie Horne <katie@coder.com> Co-authored-by: Jonathan Yu <jonathan@coder.com>
* secret name can be anything, key must be password Co-authored-by: Katie Horne <katie@coder.com>
* Clarify that the quota counts running workspaces
@@ -57,4 +57,8 @@ env | grep CODER_ | |||
<td><code>CODER_WP_NAME</code></td> | |||
<td>The name of the workspace provider hosting the environment</td> | |||
</tr> | |||
<tr> | |||
<td><code>CODER_RUNTIME</code></td> | |||
<td>Whether the workspace is a CVM or not</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
Whether the workspace is CVM-enabled or not
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is a
makes sense, since "containerized virtual machine" is a category, rather than something that can be turned on or off (this setting can't be changed after creation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I'm late to this, CODER_RUNTIME is set to the runtime name, currently either kubernetes/default
or kubernetes/sysbox
(for CVMs). The goal is that we would later support other runtimes, so this isn't a boolean flag: it is the name of the container runtime that we're using to start the workspace.
Code reference: https://github.com/cdr/m/blob/5cf9288a2b3e506dfa2b31098eaf730ce99a1a4c/product/coder/pkg/model/environments_stages.go#L283-L286
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jawnsy Thanks, I'll update this in the release branch!
✨ Coder.com for PR #410 deployed! It will be updated on every commit.
|
No description provided.