Skip to content
This repository was archived by the owner on Aug 18, 2025. It is now read-only.

Conversation

khorne3
Copy link
Contributor

@khorne3 khorne3 commented Jun 15, 2021

No description provided.

deansheather and others added 5 commits June 15, 2021 06:54
Co-authored-by: Katie Horne <katie@coder.com>
* chore: Add solution for Docker problems

Co-authored-by: Katie Horne <katie@coder.com>
Co-authored-by: Jonathan Yu <jonathan@coder.com>
* secret name can be anything, key must be password

Co-authored-by: Katie Horne <katie@coder.com>
* Clarify that the quota counts running workspaces
@khorne3 khorne3 requested a review from sreya June 15, 2021 21:03
@@ -57,4 +57,8 @@ env | grep CODER_
<td><code>CODER_WP_NAME</code></td>
<td>The name of the workspace provider hosting the environment</td>
</tr>
<tr>
<td><code>CODER_RUNTIME</code></td>
<td>Whether the workspace is a CVM or not</td>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

Whether the workspace is CVM-enabled or not

WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is a makes sense, since "containerized virtual machine" is a category, rather than something that can be turned on or off (this setting can't be changed after creation).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I'm late to this, CODER_RUNTIME is set to the runtime name, currently either kubernetes/default or kubernetes/sysbox (for CVMs). The goal is that we would later support other runtimes, so this isn't a boolean flag: it is the name of the container runtime that we're using to start the workspace.

Code reference: https://github.com/cdr/m/blob/5cf9288a2b3e506dfa2b31098eaf730ce99a1a4c/product/coder/pkg/model/environments_stages.go#L283-L286

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawnsy Thanks, I'll update this in the release branch!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2021

✨ Coder.com for PR #410 deployed! It will be updated on every commit.

@khorne3 khorne3 changed the base branch from main to release-1.20 June 15, 2021 21:54
@khorne3 khorne3 merged commit b38f8dc into release-1.20 Jun 15, 2021
@khorne3 khorne3 deleted the env-var branch June 15, 2021 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants