Skip to content
This repository was archived by the owner on Aug 18, 2025. It is now read-only.

Conversation

ericpaulsen
Copy link
Member

making this change to prevent untrusted certs from being used, and providing a sub-optimal TLS config experience for users.

@ericpaulsen ericpaulsen added the docs 📝 Improvements or additions to documentation label Jul 6, 2021
@ericpaulsen ericpaulsen requested review from IAmHughes and khorne3 July 6, 2021 15:15
@ericpaulsen ericpaulsen self-assigned this Jul 6, 2021
Copy link
Contributor

@IAmHughes IAmHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

✨ Coder.com for PR #465 deployed! It will be updated on every commit.

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use staging anywhere else in the docs?

@ericpaulsen
Copy link
Member Author

Do we use staging anywhere else in the docs?

Not that I'm aware of. The other guides actually had the production URL set, so this change will make the guides consistent.

Side note: I'm going to push another commit to fix an issue with the devurls.host value we're setting in the helm upgrade command.

@ericpaulsen ericpaulsen merged commit b2051cf into main Jul 6, 2021
@ericpaulsen ericpaulsen deleted the ericpaulsen/letsencryptProd branch July 6, 2021 16:20
@@ -104,7 +104,7 @@ To make sure that your `clusterIssuer` can change your DNS settings,
preferredChain: ""
privateKeySecretRef:
name: example-issuer-account-key
server: https://acme-staging-v02.api.letsencrypt.org/directory
server: https://acme-v02.api.letsencrypt.org/directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we provide examples for both? I imagine that someone would want to test with staging first, and then switch to production once they confirm it works, because I think the rate limits are different between staging and prod?

Copy link
Member Author

@ericpaulsen ericpaulsen Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - the rate limits are different. See here. I'm in favor of including an example for each, so users are aware of both options and can decide for themselves.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs 📝 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants