Skip to content

chore: add shared security responsibility doc #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Conversation

khorne3
Copy link
Contributor

@khorne3 khorne3 commented Sep 13, 2021

No description provided.

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #14532: Docs request: Shared Security Model.

@khorne3 khorne3 requested a review from mterhar September 13, 2021 17:15
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2021

✨ Coder.com for PR #597 deployed! It will be updated on every commit.

@bpmct
Copy link
Member

bpmct commented Sep 13, 2021

!!! this breaks the docs

@BrunoQuaresma - we need to add the health check to cdr/docs too

@bpmct
Copy link
Member

bpmct commented Sep 14, 2021

added the check so the build won't succeed next time #601

the error is because the file is named guides/admin/share-security.md

@BrunoQuaresma
Copy link
Contributor

Thanks for taking care of this. I was planning to include the check script this week.

@khorne3
Copy link
Contributor Author

khorne3 commented Sep 20, 2021

Hey @mterhar, will you have time to take a look at this sometime? Thanks!

Copy link
Contributor

@mterhar mterhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions on formatting and wording.

@khorne3 khorne3 requested a review from mterhar October 13, 2021 13:04
@khorne3 khorne3 force-pushed the katiehorne/ch14532 branch from 13610f5 to 49d4977 Compare October 13, 2021 13:52
@khorne3 khorne3 force-pushed the katiehorne/ch14532 branch from 49d4977 to 01bed04 Compare October 13, 2021 14:18
@khorne3 khorne3 merged commit a05289b into main Oct 14, 2021
@khorne3 khorne3 deleted the katiehorne/ch14532 branch October 14, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants