Skip to content

flake: TestReinit #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue May 14, 2025 · 0 comments · Fixed by coder/coder#17902
Closed

flake: TestReinit #632

spikecurtis opened this issue May 14, 2025 · 0 comments · Fixed by coder/coder#17902
Assignees
@SasSwart
Labels
flake

Comments

@spikecurtis
Copy link 

workspaceagents_test.go:2678: 
        	Error Trace:	/home/runner/work/coder/coder/coderd/workspaceagents_test.go:2678
        	            				/opt/hostedtoolcache/go/1.24.2/x64/src/runtime/asm_amd64.s:1700
        	Error:      	Received unexpected error:
        	            	execute request:
        	            	    github.com/coder/coder/v2/codersdk/agentsdk.(*Client).WaitForReinit
        	            	        /home/runner/work/coder/coder/codersdk/agentsdk/agentsdk.go:737
        	            	  - Get "http://localhost:34387/api/v2/workspaceagents/me/reinit": context deadline exceeded
        	Test:       	TestReinit
    workspaceagents_test.go:2695: 
        	Error Trace:	/home/runner/work/coder/coder/coderd/workspaceagents_test.go:2695
        	Error:      	Expected value not to be nil.
        	Test:       	TestReinit

seen here: https://github.com/coder/coder/actions/runs/15022846857/job/42216170738
@SasSwart SasSwart mentioned this issue May 19, 2025
Merged
SasSwart added a commit to coder/coder that referenced this issue May 19, 2025
@SasSwart
test: fix a race in TestReinit (#17902)
c775ea8 
closes coder/internal#632

`pubsubReinitSpy` used to signal that a subscription had happened before
it actually had.
This created a slight opportunity for the main goroutine to publish
before the actual subscription was listening. The published event was
then dropped, leading to a failed test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SasSwart SasSwart

Labels
flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix a race in TestReinit coder/coder
2 participants
@spikecurtis @SasSwart