Skip to content

refactor(dbcrypt): move key revocation process to in-api #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnstcn opened this issue Sep 7, 2023 · 0 comments
Open

refactor(dbcrypt): move key revocation process to in-api #77

johnstcn opened this issue Sep 7, 2023 · 0 comments

Comments

@johnstcn
Copy link
Member

johnstcn commented Sep 7, 2023

Context: coder/coder#9523 (comment)

The current dbcrypt rotation logic

  • Requires direct access to the database
  • May fail if a coderd instance is still running with the old key and inserts encrypted data when we attempt to revoke the old key.

Moving it to an in-API endpoint would allow for a more ergonomic key rotation process:

  • The replica that services the request can validate that it has the correct keys and is not trying to revoke its active key
  • The rotation request can now be performed by the slim CLI
  • The rotation request can now be performed without direct database access
@johnstcn johnstcn changed the title dbcrypt: move recvocation process to in-api dbcrypt: move key revocation process to in-api Sep 7, 2023
@johnstcn johnstcn changed the title dbcrypt: move key revocation process to in-api refactor(dbcrypt): move key revocation process to in-api Sep 7, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2024
@johnstcn johnstcn reopened this Mar 14, 2024
@matifali matifali transferred this issue from coder/coder Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants