Skip to content

Add header command setting #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 22, 2023
Merged

Add header command setting #303

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
673a745
Add header command setting
code-asher Sep 18, 2023
761303e
Inject header command into proxy command
code-asher Sep 18, 2023
9a9dedf
Add headers to API requests
code-asher Sep 18, 2023
af0487f
Update changelog with header command
code-asher Sep 18, 2023
06c7fb0
Add --info to CI tests
code-asher Sep 19, 2023
3704482
Unshadow header variable
code-asher Sep 22, 2023
1ceaa48
Escape slashes in header command
code-asher Sep 22, 2023
dbaf564
Disallow \n in header command
code-asher Sep 22, 2023
9b8bdb7
Update tests for escaped paths
code-asher Sep 22, 2023
a090a3c
Matche Coder CLI behavior for escaping to SSH config
code-asher Sep 22, 2023
8e5099e
Add a setting, not a path
code-asher Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unshadow header variable
  • Loading branch information
@code-asher
code-asher committed Sep 22, 2023
commit 3704482bcd44527ec4506fb23d8bf5d28248ec85
2 changes: 1 addition & 1 deletion src/main/kotlin/com/coder/gateway/sdk/CoderRestClientService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class CoderRestClient(var url: URL, var token: String, var headerCommand: String
val headers = getHeaders(url, headerCommand)
if (headers.size > 0) {
val builder = request.newBuilder()
headers.forEach { builder.addHeader(it.key, it.value) }
headers.forEach { h -> builder.addHeader(h.key, h.value) }
request = builder.build()
}
it.proceed(request)
Expand Down