Skip to content

Add header command setting #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 22, 2023
Merged

Add header command setting #303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
673a745
Add header command setting
code-asher Sep 18, 2023
761303e
Inject header command into proxy command
code-asher Sep 18, 2023
9a9dedf
Add headers to API requests
code-asher Sep 18, 2023
af0487f
Update changelog with header command
code-asher Sep 18, 2023
06c7fb0
Add --info to CI tests
code-asher Sep 19, 2023
3704482
Unshadow header variable
code-asher Sep 22, 2023
1ceaa48
Escape slashes in header command
code-asher Sep 22, 2023
dbaf564
Disallow \n in header command
code-asher Sep 22, 2023
9b8bdb7
Update tests for escaped paths
code-asher Sep 22, 2023
a090a3c
Matche Coder CLI behavior for escaping to SSH config
code-asher Sep 22, 2023
8e5099e
Add a setting, not a path
code-asher Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add header command setting
  • Loading branch information
@code-asher
code-asher committed Sep 18, 2023
commit 673a7454cd1b706ffe79bd5ebe82f732ea63ed7a
7 changes: 7 additions & 0 deletions src/main/kotlin/com/coder/gateway/CoderSettingsConfigurable.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,13 @@ class CoderSettingsConfigurable : BoundConfigurable("Coder") {
CoderGatewayBundle.message("gateway.connector.settings.enable-binary-directory-fallback.comment")
)
}.layout(RowLayout.PARENT_GRID)
row(CoderGatewayBundle.message("gateway.connector.settings.header-command.title")) {
textField().resizableColumn().align(AlignX.FILL)
.bindText(state::headerCommand)
.comment(
CoderGatewayBundle.message("gateway.connector.settings.header-command.comment")
)
}.layout(RowLayout.PARENT_GRID)
}
}

Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/com/coder/gateway/services/CoderSettingsState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class CoderSettingsState : PersistentStateComponent<CoderSettingsState> {
var dataDirectory: String = ""
var enableDownloads: Boolean = true
var enableBinaryDirectoryFallback: Boolean = false
var headerCommand: String = ""
override fun getState(): CoderSettingsState {
return this
}
Expand Down
5 changes: 5 additions & 0 deletions src/main/resources/messages/CoderGatewayBundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,8 @@ gateway.connector.settings.enable-binary-directory-fallback.title=Fall back to d
gateway.connector.settings.enable-binary-directory-fallback.comment=Checking this \
box will allow the plugin to fall back to the data directory when the CLI \
directory is not writable.
gateway.connector.settings.header-command.title=Header command:
gateway.connector.settings.header-command.comment=An external command that \
outputs additional HTTP headers added to all requests. The command must \
output each header as `key=value` on its own line. The following \
environment variables will be available to the process: CODER_URL.