fix: ignore file ownership for copy from context #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with coder/terraform-provider-envbuilder#50 👍 |
johnstcn
reviewed
Sep 24, 2024
johnstcn
reviewed
Sep 24, 2024
johnstcn
reviewed
Sep 24, 2024
johnstcn
reviewed
Sep 24, 2024
| - uses: actions/checkout@b0e28b5ac45a892f91e7d036f8200cf5ed489415 # v3 | ||
| # Some unit tests need to be run as root to function correctly as they | ||
| # may attempt to run `chown`. | ||
| - run: sudo make test |
There was a problem hiding this comment.
This is most unfortunate and makes me sad. We'd need to refactor a significant part of kaniko to make this not be needed.
johnstcn
reviewed
Sep 25, 2024
mafredri
commented
Sep 25, 2024
johnstcn
approved these changes
Sep 25, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for caching when context files permissions change. This is irrelevant for a
COPYoperation since the they are either copied asroot:root, or a specific owner/group depending onCOPY --chown=argument.Relates to coder/terraform-provider-envbuilder#43