Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

fix(jfrog-token)!: add attributes to fine control the token behaviour #100

Merged
merged 7 commits into from
Nov 15, 2023
Merged

fix(jfrog-token)!: add attributes to fine control the token behaviour #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a89b5ce
fix(jfrog-token): add `check_license` attribute to skip pre-flight li…
matifali Nov 15, 2023
a96fe3f
use `checj_license = true` by default
matifali Nov 15, 2023
6005ec1
update description
matifali Nov 15, 2023
33cbee9
add `refreshable` and `expires_in` attributess
matifali Nov 15, 2023
baf1936
fix: make `expires_in` type number
matifali Nov 15, 2023
534ab32
update `username_field` default to `username`
matifali Nov 15, 2023
3082498
Update README.md
matifali Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jfrog-token/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ Install the JF CLI and authenticate package managers with Artifactory using Arti
module "jfrog" {
source = "https://registry.coder.com/modules/jfrog-token"
agent_id = coder_agent.example.id
jfrog_url = "https://YYYY.jfrog.io"
artifactory_access_token = var.artifactory_access_token # An admin access token
jfrog_url = "https://XXXX.jfrog.io"
artifactory_access_token = var.artifactory_access_token
package_managers = {
"npm": "npm",
"go": "go",
Expand All @@ -26,7 +26,7 @@ module "jfrog" {
}
```

Get a JFrog access token from your Artifactory instance. The token must have admin permissions. It is recommended to store the token in a secret terraform variable.
Get a JFrog access token from your Artifactory instance. The token must be an [admin token](https://registry.terraform.io/providers/jfrog/artifactory/latest/docs#access-token). It is recommended to store the token in a secret terraform variable.

```hcl
variable "artifactory_access_token" {
Expand Down
30 changes: 25 additions & 5 deletions jfrog-token/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,28 @@ variable "artifactory_access_token" {
description = "The admin-level access token to use for JFrog."
}

variable "check_license" {
type = bool
description = "Toggle for pre-flight checking of Artifactory license. Default to `true`."
default = true
}

variable "refreshable" {
type = bool
description = "Is this token refreshable? Default is `false`."
default = false
}

variable "expires_in" {
type = number
description = "The amount of time, in seconds, it would take for the token to expire."
default = null
}

variable "username_field" {
type = string
description = "The field to use for the artifactory username. i.e. Coder username or email."
default = "email"
description = "The field to use for the artifactory username. Default `username`."
default = "username"
validation {
condition = can(regex("^(email|username)$", var.username_field))
error_message = "username_field must be either 'email' or 'username'"
Expand Down Expand Up @@ -58,16 +76,18 @@ locals {

# Configure the Artifactory provider
provider "artifactory" {
url = join("/", [var.jfrog_url, "artifactory"])
access_token = var.artifactory_access_token
url = join("/", [var.jfrog_url, "artifactory"])
access_token = var.artifactory_access_token
check_license = var.check_license
}

resource "artifactory_scoped_token" "me" {
# This is hacky, but on terraform plan the data source gives empty strings,
# which fails validation.
username = length(local.username) > 0 ? local.username : "dummy"
scopes = ["applied-permissions/user"]
refreshable = true
refreshable = var.refreshable
expires_in = var.expires_in
}

data "coder_workspace" "me" {}
Expand Down