wgengine/netstack: disable TCP SACK #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
May 22, 2023
There was a problem hiding this comment.
I tried this against coder/coder#7414 and it seems like the issue still persists, although perhaps not quite as frequently.
I don't see any harm in disabling this either way though. 👍🏻
It was my observation too. I'm curious if it helps in the reported use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: coder/coder#7388
This PR disables TCP SACK (enabled by default) as in other experiments with MinRTO, MaxRTO tweaking didn't work. The idea is to keep this fix until the issue in gvisor is resolved. It also reverts #24.
I will follow-up with PR to coder/coder.