Log all changes to magicSock best addr #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tailscale logs when UDP routes are set, but not when they are unset, so I've added logs to cover all the places
bestAddrchanges. c.f. coder/coder#7962I've also removed the logs dropped in
setPeerLastDerpLockedbecause they are spammy and not useful.Once upon a time it was the case that magicsock communicated with a peer exclusively via a single DERP region, but they later added various optimizations that mean that the magicsock sends DERP messages both via its home DERP and the peer's home DERP. If these are different regions, we get a ton of logs every time it switches.