Skip to content

feat: add order to coder_parameter #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jun 27, 2023

Related: coder/coder#8193

This PR adds order property to coder_parameter to determine the position of parameters presented in the UI/CLI form. More details can be found in the related issue.

@mtojek mtojek self-assigned this Jun 27, 2023
@mtojek mtojek force-pushed the 8193-priority-ui branch from 43eadc6 to d81eec6 Compare June 27, 2023 09:47
@mtojek mtojek requested review from bpmct, spikecurtis and mafredri June 27, 2023 09:51
@mtojek mtojek marked this pull request as ready for review June 27, 2023 09:52
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻. Do we need a test to check it as well?

@mtojek
Copy link
Member Author

mtojek commented Jun 27, 2023

Do we need a test to check it as well?

Done!

@mtojek
Copy link
Member Author

mtojek commented Jun 28, 2023

I adjusted the PR to follow recent product expectations. Would you mind taking another look?

@mtojek mtojek changed the title feat: add priority to coder_parameter feat: add order to coder_parameter Jun 28, 2023
@mtojek mtojek requested review from mafredri and spikecurtis June 28, 2023 13:11
@mtojek mtojek merged commit 09c3ada into coder:main Jun 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants