feat: Validate monotonicity for coder_parameter #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Feb 3, 2023
| "monotonic": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Description: "Number monotonicity, either increasing or decreasing.", |
There was a problem hiding this comment.
Just curious: Why don't we use a validation func here?
(I do see the check in valueIsType, it's just not obvious why we're doing that instead of validation func.)
There was a problem hiding this comment.
I will pass this question to @kylecarbs who originally implemented this code. I deduce that this is due to the compliance with terraform-plugin-sdk?
deansheather
approved these changes
Feb 3, 2023
kylecarbs
approved these changes
Feb 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: coder/coder#5574
Related: coder/coder#5978
This PR adds a new validation property
monotonicto thecoder_parameter. Unfortunately, we can only validate the format within the Terraform runner, but a comparison of values, current and new, will be performed on thecoderdAPI level.