Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other patches related to this removal have been kept but this file managed to make it back in.
The problem with the yarnrc is that it compiles modules for the wrong target (Electron) so we get Node module version errors among other issues (like "module did not self-register" whatever that means).
For anyone looking to replicate use this Dockerfile:
cd
to that directorydocker build . -t code-server-test
docker run --rm code-server-test bash -c 'cd code-server && yarn && yarn watch
docker run --rm code-server-test bash -c 'cd code-server/vendor && yarn add --modules-folder modules --ignore-scripts --dev code-oss-dev@code-asher/vscode#e225960dcaa469a134865b17169b6ebd3c45dd3f && cd .. && yarn && yarn watch