Skip to content

Restore yarnrc removal #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Restore yarnrc removal #4

merged 1 commit into from
Oct 7, 2021

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Oct 7, 2021

The other patches related to this removal have been kept but this file managed to make it back in.

The problem with the yarnrc is that it compiles modules for the wrong target (Electron) so we get Node module version errors among other issues (like "module did not self-register" whatever that means).

For anyone looking to replicate use this Dockerfile:

FROM debian:11

RUN apt-get update \
 && apt-get install -y \
    git \
    curl \
    build-essential \
    g++ \
    libx11-dev \
    libxkbfile-dev \
    libsecret-1-dev \
    python-is-python3 \
    jq

RUN curl -sL https://deb.nodesource.com/setup_14.x | bash -

RUN apt-get update && apt-get install -y \
  nodejs

RUN npm install -g yarn

RUN git clone https://github.com/cdr/code-server.git
  1. Save the above as Dockerfile into an empty directory
  2. cd to that directory
  3. Run docker build . -t code-server-test
  4. Run docker run --rm code-server-test bash -c 'cd code-server && yarn && yarn watch
  5. Observe eventual spdlog error
  6. Kill container
  7. Run docker run --rm code-server-test bash -c 'cd code-server/vendor && yarn add --modules-folder modules --ignore-scripts --dev code-oss-dev@code-asher/vscode#e225960dcaa469a134865b17169b6ebd3c45dd3f && cd .. && yarn && yarn watch
  8. No spdlog errors!

Copy link

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for posting the repro notes! This all sounds good to me.

@code-asher code-asher merged commit f976a07 into coder:code-server Oct 7, 2021
@code-asher code-asher deleted the yarnrc branch October 7, 2021 18:50
@code-asher code-asher restored the yarnrc branch October 7, 2021 18:51
@jsjoeio
Copy link

jsjoeio commented Oct 7, 2021

P.S. I tested this locally and it seems to have fixed our broken terminal tests!

image

@code-asher code-asher mentioned this pull request Oct 8, 2021
@code-asher code-asher deleted the yarnrc branch October 8, 2021 20:03
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this pull request Dec 23, 2021
I was getting module issues again.  See
coder#4 for details.
ZauberNerd pushed a commit to ZauberNerd/vscode that referenced this pull request Dec 23, 2021
I was getting module issues again.  See
coder#4 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants