Skip to content

feat: add VS code notifications for workspace actions #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 27, 2023
Merged

feat: add VS code notifications for workspace actions #111

merged 17 commits into from
Jun 27, 2023

Conversation

Kira-Pilot
Copy link
Member

@Kira-Pilot Kira-Pilot commented Jun 21, 2023 •
edited
Loading

Opening this PR in place of #110 as this solution is a little cleaner.
This resolves coder/coder#7360
Screenshot 2023-06-22 at 12 33 03 PM

@Kira-Pilot Kira-Pilot mentioned this pull request Jun 21, 2023
Closed
@Kira-Pilot Kira-Pilot requested review from code-asher and removed request for rodrimaia June 22, 2023 17:33
Kira-Pilot
Kira-Pilot commented Jun 22, 2023
View reviewed changes
code-asher
code-asher reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love to see the # syntax at work.

I have not tried it out yet since when I build it tells me deleting_at does not exist. Do we need to update the coder dependency maybe?

code-asher
code-asher reviewed Jun 22, 2023
View reviewed changes
@Kira-Pilot
Copy link
Member Author

Kira-Pilot commented Jun 23, 2023 •
edited
Loading

I have not tried it out yet since when I build it tells me deleting_at does not exist. Do we need to update the coder dependency maybe?

Done! Let me know if you still see that error.

code-asher
code-asher approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@Kira-Pilot Kira-Pilot merged commit 713b2bd into main Jun 27, 2023
@Kira-Pilot Kira-Pilot deleted the workspace-action-notifications/kira-pilot branch June 27, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workspace actions: add VS Code notifications for workspace messaging
2 participants
@Kira-Pilot @code-asher