Skip to content

chore: update Node.js version to 20 #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

chore: update Node.js version to 20 #522

merged 1 commit into from
May 28, 2025

Conversation

matifali
Copy link
Member

@matifali matifali commented May 28, 2025 •
edited
Loading

This PR updates the Node.js version used in CI and release workflows from 18 to 20.

Testing

  • Ran tests with Node 20 locally and all tests passed

Closes #521

@matifali matifali requested review from code-asher and a team May 28, 2025 12:05
BrunoQuaresma
BrunoQuaresma reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update it in dogfood and packge.json files.

@matifali
Copy link
Member Author

matifali commented May 28, 2025 •
edited
Loading

We also need to update it in dogfood and package.json files.

I do not see Node version constraint in package.json, and the dogfood image is out of scope here.

@matifali matifali merged commit 640d97f into main May 28, 2025
2 checks passed
@matifali matifali deleted the update-node20 branch May 28, 2025 13:01
matifali added a commit that referenced this pull request May 28, 2025
@matifali
Revert "chore: update Node.js version to 20 (#522)"
c7b0d1d 
This reverts commit 640d97f.
@matifali matifali mentioned this pull request May 28, 2025
Merged
@code-asher
Copy link
Member

I see this was reverted, but when we do this again we should also update the flake.

Probably not a bad idea to use node-version-file: .node-version instead of node-version in the workflow as well, and create a .node-version file with the version in it so we have just one place to control it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@code-asher code-asher Awaiting requested review from code-asher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Node 20
3 participants
@matifali @code-asher @BrunoQuaresma