Skip to content

Revert "chore: update Node.js version to 20" #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Revert "chore: update Node.js version to 20" #523

merged 1 commit into from
May 28, 2025

Conversation

matifali
Copy link
Member

Reverts #522

This causes yarn build to fail, probably due to some type-checking issues.

ERROR in /Users/matifali/repos/coder/vscode-coder/src/workspacesProvider.ts
./src/workspacesProvider.ts 251:20-28
[tsl] ERROR in /Users/matifali/repos/coder/vscode-coder/src/workspacesProvider.ts(251,21)
      TS2339: Property 'statuses' does not exist on type 'WorkspaceApp'.
 @ ./src/extension.ts 47:29-60

ERROR in /Users/matifali/repos/coder/vscode-coder/src/workspacesProvider.ts
./src/workspacesProvider.ts 251:36-44
[tsl] ERROR in /Users/matifali/repos/coder/vscode-coder/src/workspacesProvider.ts(251,37)
      TS2339: Property 'statuses' does not exist on type 'WorkspaceApp'.
 @ ./src/extension.ts 47:29-60

ERROR in /Users/matifali/repos/coder/vscode-coder/src/workspacesProvider.ts
./src/workspacesProvider.ts 252:39-47
[tsl] ERROR in /Users/matifali/repos/coder/vscode-coder/src/workspacesProvider.ts(252,40)
      TS2339: Property 'statuses' does not exist on type 'WorkspaceApp'.
 @ ./src/extension.ts 47:29-60

3 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.98.0 compiled with 3 errors in 2030 ms
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@matifali matifali merged commit 3cf861a into main May 28, 2025
2 checks passed
@matifali matifali deleted the revert-522-update-node20 branch May 28, 2025 14:28
@code-asher
Copy link
Member

This makes me think we should add a yarn build job to ci.yaml to validate the build works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@code-asher code-asher Awaiting requested review from code-asher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matifali @code-asher @BrunoQuaresma